Edit mongodb provider#139
Open
alibazregar wants to merge 29 commits into
Open
Conversation
Qamsari
reviewed
Nov 24, 2024
| setting.deform | ||
| ); | ||
| const dirPath = path.dirname(destinationPath); | ||
| await fs.promises.mkdir(dirPath, { recursive: true }); |
Contributor
There was a problem hiding this comment.
Please check that the directory does not exist before creating it.
check Index4Response._createDirectoryIfNotExist()
| @@ -82,10 +82,7 @@ export default class SourceCommand extends CommandBase { | |||
| params: JSON.stringify(paramList), | |||
| } | |||
| context.debugContext.addDebugInformation(`Parameter(s) Send To '${sourceName}' From Command '${connectionName}' in 180 ms`,[debugParams]) | |||
Contributor
There was a problem hiding this comment.
hard code time?! in 180 ms
| * @returns {Promise<DataSourceCollection>} | ||
| */ | ||
| loadDataAsync(parameters, cancellationToken) { | ||
| loadDataAsync(parameters, cancellationToken,options) { |
Contributor
There was a problem hiding this comment.
Why do we need options here?
Qamsari
reviewed
Nov 25, 2024
Comment on lines
+63
to
+65
| async insertAsync(sourceName, connectionName, databaseName, collectionName, data) { | ||
| throw new Error("ConnectionInfo.insertAsync() method not implemented."); | ||
| } |
Contributor
There was a problem hiding this comment.
Why should this method be declared in the base class?
Declare internally in the related class
Comment on lines
160
to
162
| if (!fs.existsSync(pathDirectory)) { | ||
| fs.mkdirSync(pathDirectory); | ||
| fs.mkdirSync(pathDirectory,{recursive : true}); | ||
| } |
Contributor
There was a problem hiding this comment.
Why should we not use Index4Response._createDirectoryIfNotExist(pathDirectory)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.