adding json content type support#83
Open
alibazregar wants to merge 1 commit into
Open
Conversation
Qamsari
reviewed
Feb 20, 2024
| }); | ||
| bb.on("close", createCmsAndCreateResponseAsync); | ||
| stream.pipe(bb); | ||
| } else if (method === "POST") { |
Contributor
There was a problem hiding this comment.
please check this type of code for read json.
busboy.on('finish', function() {
// use req.body
})| const url = headers[":path"]; | ||
| const createCmsAndCreateResponseAsync = async () => { | ||
| let date = new Date(); | ||
| console.log( |
Contributor
There was a problem hiding this comment.
Remove this after test and before create pr
| content.name = info.filename; | ||
| content.payload = Buffer.concat(ContentParts); | ||
| fileContents.push(content); | ||
| bodyParser.json()(req, res, (err) => { |
Contributor
There was a problem hiding this comment.
In other case (non json content) this code work? it is tested?
Collaborator
Author
There was a problem hiding this comment.
yes; it works on non secure version of fingerfood but needs to write some unit tests for it to make sure
| content.name = info.filename; | ||
| content.payload = Buffer.concat(ContentParts); | ||
| fileContents.push(content); | ||
| bodyParser.json()(req, res, (err) => { |
Contributor
There was a problem hiding this comment.
In other case (non json content) this code work? it is tested?
Collaborator
Author
There was a problem hiding this comment.
i check that; with some test
| "dependencies": { | ||
| "alasql": "^4.1.9", | ||
| "axios": "^1.6.2", | ||
| "body-parser": "^1.20.2", |
Collaborator
Author
There was a problem hiding this comment.
check this mscdex/busboy#125; busboy dont support application/json content-type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.