[pull] develop from smartcontractkit:develop#544
Merged
pull[bot] merged 6 commits intoMarcelRaschke:developfrom Apr 13, 2026
Merged
[pull] develop from smartcontractkit:develop#544pull[bot] merged 6 commits intoMarcelRaschke:developfrom
pull[bot] merged 6 commits intoMarcelRaschke:developfrom
Conversation
update gitref
…sts (#21968) * fix(test): prevent goroutine leak in PausableTicker and CronTicker tests PausableTicker.Destroy() stops the ticker but doesn't close the channel. Goroutines running for-range on Ticks() block forever, accumulating across -count=N iterations. Add done channels so goroutines exit when the test completes. Also reduce CronTicker verification sleep from 1s to 200ms. Fixes: CORE-2401 * revert CronTicker verification sleep back to 1s
…ision (#21977) * fix(ci): pass unique artifact-name per matrix job to prevent 409 collision Multiple matrix jobs with trunk-auto-quarantine enabled (go_core_tests, go_core_tests_integration, go_core_ccip_deployment_tests) all upload an artifact named 'individual_test_logs' in the same workflow run, causing a deterministic 409 conflict that fails CI even when tests pass. Pass artifact-name: ${{ matrix.type.cmd }}_test_logs so each job gets a unique artifact name. Depends on smartcontractkit/.github#1512. Fixes: CORE-2418 * fix(ci): pass unique artifact-name to branch-out-upload in CRE workflows Prevents 409 conflict when multiple matrix jobs fail simultaneously and attempt to upload artifacts with the same hardcoded name. Fixes: smartcontractkit/.github/actions/branch-out-upload (artifact-name input)
…eport in nodetestutils (#21980) * fix(deployment): replace hashicorp freeport with smartcontractkit/freeport in nodetestutils The move commit fd31642 re-introduced github.com/hashicorp/consul/sdk/freeport into node.go, undoing the repo-wide swap done in 8315b51. The hashicorp library has a TOCTOU race — it briefly binds to check port availability then releases, allowing other CI processes to steal the port before the test binds. The smartcontractkit fork avoids this by holding a TCP listener on an entire port block for the lifetime of the process. Fixes CORE-2375. * fix(deployment): fix goimports and go mod tidy after freeport swap Run goimports to fix import ordering in nodetestutils/node.go and run go mod tidy in deployment, integration-tests, and integration-tests/load to remove the now-unused github.com/hashicorp/consul/sdk dependency.
…n OCR3 (#21959) Global Prometheus counters/histograms registered via promauto accumulate across test iterations when running with -count=N. Tests that assert exact absolute values fail on the 2nd+ iteration. Fix by capturing initial metric values before test operations and asserting on the delta instead. Fixes: CORE-2374
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )