fix(tests): properly fix MA0074 instead of suppressing#115
Merged
Conversation
Fix MA0074 properly in GeneratorDriverTests by passing StringComparison.Ordinal instead of suppressing the rule. Tests inspect Roslyn generator output (file paths) which is ASCII; ordinal is correct semantically and lets the analyzer keep enforcing the rule elsewhere. Removes the tests-wide MA0074 suppression added in #114.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the tests-wide MA0074 suppression added in #114 with the actual fix: pass
StringComparison.Ordinalto the 24FilePath.Contains(...)calls in GeneratorDriverTests. Ordinal is the right semantic for inspecting Roslyn generator output (ASCII file paths) and keeps the analyzer active everywhere else in tests.