Repository navigation
ci: lint, build and typecheck on PRs and main - #7
Merged
Merged
Conversation
Adds lint (eslint) and typecheck (tsc) scripts and a workflow reusing the shared ci-node workflow from MarcoPeretti/updatebot, so dependency update PRs have checks to gate on. Typecheck runs after build because image imports need the next-env.d.ts the build generates. POSTGRES_URL is left unset so next.config.ts skips the redirects query. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
package.json: addlint(eslint .) andtypecheck(tsc --noEmit) scripts..github/workflows/ci.yml: on PRs and pushes tomain, runs lint, build and typecheck (Node 24, pnpm) by reusingMarcoPeretti/updatebot/.github/workflows/ci-node.yml.renovate.json(second commit): drops the temporary "never automerge" rule, so the shared preset applies as designed.Notes
tscfails on the image imports becausenext-env.d.ts(gitignored) is generated by the build.POSTGRES_URLis deliberately unset in CI:next.config.tsskips the redirects query when it is missing; a dummy value would make it try to connect./bookspage fetches Goodreads RSS at build time, so a Goodreads outage could fail the build job.Decide before merging: the second commit
Vercel deploys from
main, so once Renovate automerge is on, a merged update PR is also a production deploy. CI (lint, build, typecheck) and Vercel's own build are the only gates. If you would rather review dependency PRs here, drop the second commit (the automerge-off rule stays).Tested locally
Clean clone:
pnpm install --frozen-lockfile,eslint .(clean),pnpm buildwithPOSTGRES_URLunset (19 pages, 11s),tsc --noEmitafter build (clean).🤖 Generated with Claude Code