ci: start ClickHouse while the test archives download - #589
Closed
MarcusKainth wants to merge 1 commit into
Closed
MarcusKainth wants to merge 1 commit into
MarcusKainth wants to merge 1 commit into
Conversation
A test job ran `make up` first and waited for the server to report healthy, 15 to 27 s, before installing nextest and downloading the archives. None of those need the server. The job now starts `docker compose up -d --wait` in the background as its first step after checkout, writing its log and exit status under RUNNER_TEMP. Before the suites, "Wait for ClickHouse" waits for that status, prints the log, and runs `make up`, which returns at once when the server answers and starts it itself when it doesn't.
Owner
Author
|
Closing: the measurement doesn't support it. Median seconds from a test job's start to its suites step: 22.5 on #588's run 36125404729 (plain |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #588 (
ci/sim-groups-start-early); the diff against that branch is this one commit.What this changes, and why
A test job runs
make upfirst and waits 15 to 27 s for the server to report healthy. Only then does it install nextest and download the archives, and neither of those needs the server.Both test jobs now start
docker compose up -d --waitin the background as their first step after checkout, and write its log and exit status underRUNNER_TEMP. Before the suites, "Wait for ClickHouse" waits for that status, prints the log and runsmake up.make upreturns at once when the server answers, and starts the server itself when it doesn't, so a failed background start still fails loudly in that step.differential-smokekeeps its plainmake up, because its next step is a release build that takes longer than the server does to start.Evidence
Step times on this PR's CI run: pending.
Invariants
None. CI step order only.
Spec impact
Checks
make gatesWritten mostly by Claude Opus 5.5.