Document node parameters and add config-file based launch - #5
Merged
Conversation
- Add launch/sinusoidal_force_sensor_launch.py for the example sinusoidal_force_sensor node, loading parameters from config/config.yaml (name + config_file launch arguments). - Add config/config.yaml with a parameter block for the example node. The node declares no ROS parameters today (constants are hardcoded), so the block is an empty placeholder kept for the standard config-file pattern. - Add a 'ROS 2 Nodes & Parameters' section to the README documenting the node and noting it has no parameters. - Install the launch and config directories into the package share dir. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the standard "ROS 2 Nodes & Parameters" README section and adds a config-file-based launch for the example node.
launch/sinusoidal_force_sensor_launch.pyfor thesinusoidal_force_sensorexample node, loading parameters fromconfig/config.yamlvianame+config_filelaunch arguments.config/config.yamlwith a parameter block for the example node. The node currently declares no ROS parameters (amplitude/frequency/tick rate are hardcoded constants insrc/examples/sinusoidal_force_sensor.cpp), so the block is an empty placeholder kept so the node follows the standard config-file pattern.ROS 2 Nodes & ParametersREADME section documenting the node and noting it has no parameters.launch/andconfig/directories into the package share directory.Verification
python3 -m py_compile launch/sinusoidal_force_sensor_launch.pypasses.config/config.yamlparses.Note: this PR was created by an AI agent (OpenHands) on behalf of the user.