Standardize Docker/Compose and CMake 3.11 - #2
Closed
mmmarinho wants to merge 3 commits into
Closed
Conversation
- Add COPY directive to Dockerfile to copy source into image - Change compose.yml build context to parent directory with explicit dockerfile path - Remove source volume mounts from compose.yml - Keep X11/privileged volumes where required for GUI/USB access - Fix incorrect directory names in Dockerfiles (matching repo name) - Fix incorrect service names in compose.yml (matching repo name) This PR was created by an AI agent (OpenHands) on behalf of mmmarinho.
The build context changed from '.' (docker/) to '..' (repo root), so 'COPY install.sh' must become 'COPY docker/install.sh'.
Contributor
Author
|
This doesnt do anything? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize Docker/Compose and CMake version:
COPYsource into image instead of volume mounts; uniformbuildconfig incompose.ymlcmake_minimum_required(VERSION 3.11)(aligned with all other SAS submodules)This PR was created by an AI agent (OpenHands) on behalf of the user.