This repository was archived by the owner on Aug 10, 2022. It is now read-only.
* Upgraded to Swift 5 and Xcode 10.2 project settings#6
Open
Song-Street wants to merge 8 commits into
Open
Conversation
Song-Street
commented
Jun 3, 2019
Song-Street
commented
- Upgraded to Swift 5 and Xcode 10.2 project settings
MarioIannotta
suggested changes
Jun 4, 2019
Owner
MarioIannotta
left a comment
MarioIannotta
left a comment
There was a problem hiding this comment.
Hello there, thanks for the effort, I've pointed out a few issues
| spec.version = '1.4' | ||
| spec.license = { :type => 'MIT', :file => 'LICENSE' } | ||
| spec.homepage = 'https://github.com/MarioIannotta/MIAlertController' | ||
| spec.homepage = 'https://github.com/Song-Street/MIAlertController' |
Owner
There was a problem hiding this comment.
Please revert this, let's point to the master repository
| spec.authors = { 'Mario Iannotta' => 'info@marioiannotta.com' } | ||
| spec.summary = 'A simple fully customizable alert controller' | ||
| spec.source = { :git => 'https://github.com/MarioIannotta/MIAlertController.git', :tag => spec.version.to_s } | ||
| spec.source = { :git => 'https://github.com/Song-Street/MIAlertController.git', :tag => spec.version.to_s, } |
|
|
||
| // Message | ||
| public var messageLabelFont = UIFont.systemFont(ofSize: 16) | ||
| public var messageLabelFont = UIFont.systemFont(ofSize: 16, weight: UIFont.Weight.light) |
Owner
There was a problem hiding this comment.
this could be UIFont.systemFont(ofSize: 16, weight: .light)
|
|
||
| public enum `Type` { | ||
|
|
||
Owner
There was a problem hiding this comment.
Please don't commit this kind of changes
| font: UIFont.systemFont(ofSize: 16), | ||
| textColor: UIColor(red: 33/255.0, green: 129/255.0, blue: 247/255.0, alpha: 1), | ||
| textAlignment: .center, | ||
| textAlignment: UIControl.ContentHorizontalAlignment.center, |
| let button = UIButton(frame: CGRect(x: 0, y: 0, width: 100, height: config.buttonHeight)) | ||
|
|
||
| button.setTitle(title, for: UIControlState()) | ||
| button.setTitle(title, for: UIControl.State()) |
Owner
There was a problem hiding this comment.
This could be just .State()
|
|
||
| transitionContext.completeTransition(completed) | ||
|
|
||
| } |
Owner
There was a problem hiding this comment.
As written before, please don't commit insubstantial changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.