Fix AnnotatePoint positioning bug #2732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #2728
Refer to #2728 (comment) for detailed explanation of issue and the fix employed
TLDR:
offsetWidthandoffsetHeightoffsetWidthandoffsetHeightwill return 0top: -Infinity%, left: -Infinity%cssAnything you'd like to highlight/discuss:
NIL
Testing instructions:
markbind serve -dProposed commit message: (wrap lines at 72 characters)
Fix AnnotatePoint positioning bug
Add ResizeObserver to recompute and update AnnotatePoint
position whenever the Tab is opened or closed
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):