Skip to content

fix(duel): restore wager button contrast across themes - #61

Merged
Maseeek merged 1 commit into
mainfrom
feat/theme-toggle
Oct 11, 2026
Merged

Maseeek merged 1 commit into
mainfrom
feat/theme-toggle

Conversation

@Maseeek

@Maseeek Maseeek commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Issue

Closes #60

Summary

Set wager and selected wager periods had dark text on dark backgrounds in light mode. Reuse the app's primary-action styling to keep their text readable in both themes. Set wager also gets a 40px hit area and a keyboard focus outline.

Set wager / selected period
- bg-zinc-800 text-white
+ bg-white text-black

Evidence

Before: browser computed styles showed rgb(15, 20, 28) text on zinc-800 for both Set wager and the selected Weekly control in light mode.

After: Set wager contrast is 18.47:1 in light mode and 21:1 in dark mode; hover contrast is 13.63:1 and 16.55:1. Both selected period controls have the same readable primary colours.

Verification

  • npm run check passed typechecking, ESLint, and all 134 tests. ESLint reports one existing missing-dependency warning in src/lib/store.tsx:544.
  • Inspected the running app in Chromium in light and dark themes, including desktop and 390px mobile layouts, label/icon contrast, hover, opening New Wager, switching Weekly/Monthly, and Cancel. Mobile had no horizontal overflow.
  • git diff --check passed.

Merge Danger

Door: two-way

Blast Radius: Duel

Only three styling class strings change in DuelView.

Reuse the existing primary action colours for Set wager and selected wager periods so light-theme compatibility rules preserve readable text. Give Set wager a 40px hit area and a visible keyboard focus outline.
@vercel

vercel Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
do-it Ready Ready Preview Oct 11, 2026 5:33pm UTC

@Maseeek
Maseeek merged commit e7b284e into main Oct 11, 2026
3 checks passed

This branch was successfully deployed

1 active deployment
Preview — d262d565 Deployed Oct 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Duel Set wager button contrast across themes

1 participant