Repository navigation
fix(duel): restore wager button contrast across themes - #61
Merged
Merged
Conversation
Reuse the existing primary action colours for Set wager and selected wager periods so light-theme compatibility rules preserve readable text. Give Set wager a 40px hit area and a visible keyboard focus outline.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #60
Summary
Set wager and selected wager periods had dark text on dark backgrounds in light mode. Reuse the app's primary-action styling to keep their text readable in both themes. Set wager also gets a 40px hit area and a keyboard focus outline.
Evidence
Before: browser computed styles showed rgb(15, 20, 28) text on zinc-800 for both Set wager and the selected Weekly control in light mode.
After: Set wager contrast is 18.47:1 in light mode and 21:1 in dark mode; hover contrast is 13.63:1 and 16.55:1. Both selected period controls have the same readable primary colours.
Verification
npm run checkpassed typechecking, ESLint, and all 134 tests. ESLint reports one existing missing-dependency warning insrc/lib/store.tsx:544.git diff --checkpassed.Merge Danger
Door: two-way
Blast Radius: Duel
Only three styling class strings change in DuelView.