Repository navigation
Per-feature deviation report in the build (phase 3) - #15
Merged
Merged
Conversation
The build now reports what it did per feature, and which parts of the source it could not represent with the feature tree: a new pure module core/status.py carries an ExecutionLedger (one outcome per planned op, merged by severity skipped > deferred > recovered/fallback > rebuilt, details merged at equal rank), world-site points per planned op, an attribution that assigns each plan_corrections component to the nearest feature's site (tol = 10% of the part diagonal; components outside any site stay freeform), one FeatureRow per planned op plus unplanned and undressable detections, and a Report-view table with volume ratios. build_body wires the ledger into every executor branch: _rollback_if_broken keys each op and records deferred/recovered/skipped, the deferred-cut retries carry their keys, the dressup loop maps block indices onto the fillet/chamfer lists, and the final table prints and lands on plan.feature_report. Counterbore/countersink sub-cuts report into their parent row's DETAIL, never its status: a sub-skip must not mask a recovered parent bore, and a rebuilt parent must not hide a failed taper (design-notes 53). plan.src_volume is set where the source mesh is still at hand (ui, RebuildBody) so the table can quote body/corrected ratios. Also fixes a pre-existing latent shadowing: the hole property loop and the cone/sphere/torus loops rebounded build_body's name parameter, which the report now prints -- the loop variable is renamed and the body name captured before any loop. Tests: 14 new headless tests (ledger merge rules, attribution, row invariants over the corpus plate and the issue-#5 bracket, formatter); the FreeCAD smoke gains two feature-report checks. Docs: ROADMAP phase 3 status, VERIFY section 6, design-notes 53, README capability bullet.
MasoudMiM
added a commit
that referenced
this pull request
Nov 9, 2026
Per-feature deviation report merged to main from feature/deviation-report (PR #15); the status line still said 'in development' with the branch name. Mark it done, ships-in-next-release, matching the Phase 1/2 phrasing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ROADMAP phase 3: one report-view row per planned feature with its execution outcome and its attributed deviation, so the feature tree stays the deliverable and the patch pass's work stays visible.
core/status.py: ExecutionLedger (severity merge), op sites, correction-to-feature attribution, FeatureRows, formatter — no FreeCAD.build_bodyrecords every branch (rollback/recover/defer/skip; dressup index mapping) and prints the table + attachesplan.feature_report.nameshadowing that made the table print a hole property key as the body name.Test evidence: 14 new headless tests → 594 passed / 1 xfailed; FreeCAD headless smoke 122 checks / 0 fails (incl. 2 new feature-report checks); manual GUI check on the corpus plate — table renders with correct body name, legend, and rows matching the 7 correction components exactly.