Skip to content

Per-feature deviation report in the build (phase 3) - #15

Merged
MasoudMiM merged 1 commit into
mainfrom
feature/deviation-report
Nov 9, 2026
Merged

MasoudMiM merged 1 commit into
mainfrom
feature/deviation-report

Conversation

@MasoudMiM

@MasoudMiM MasoudMiM commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Adds ROADMAP phase 3: one report-view row per planned feature with its execution outcome and its attributed deviation, so the feature tree stays the deliverable and the patch pass's work stays visible.

  • New pure module core/status.py: ExecutionLedger (severity merge), op sites, correction-to-feature attribution, FeatureRows, formatter — no FreeCAD.
  • build_body records every branch (rollback/recover/defer/skip; dressup index mapping) and prints the table + attaches plan.feature_report.
  • Sub-cut (counterbore/countersink) outcomes roll into the parent row's detail, never its status (design-notes 53).
  • Fixes latent name shadowing that made the table print a hole property key as the body name.

Test evidence: 14 new headless tests → 594 passed / 1 xfailed; FreeCAD headless smoke 122 checks / 0 fails (incl. 2 new feature-report checks); manual GUI check on the corpus plate — table renders with correct body name, legend, and rows matching the 7 correction components exactly.

The build now reports what it did per feature, and which parts of the
source it could not represent with the feature tree: a new pure module
core/status.py carries an ExecutionLedger (one outcome per planned op,
merged by severity skipped > deferred > recovered/fallback > rebuilt,
details merged at equal rank), world-site points per planned op, an
attribution that assigns each plan_corrections component to the nearest
feature's site (tol = 10% of the part diagonal; components outside any
site stay freeform), one FeatureRow per planned op plus unplanned and
undressable detections, and a Report-view table with volume ratios.

build_body wires the ledger into every executor branch:
_rollback_if_broken keys each op and records deferred/recovered/skipped,
the deferred-cut retries carry their keys, the dressup loop maps block
indices onto the fillet/chamfer lists, and the final table prints and
lands on plan.feature_report. Counterbore/countersink sub-cuts report
into their parent row's DETAIL, never its status: a sub-skip must not
mask a recovered parent bore, and a rebuilt parent must not hide a
failed taper (design-notes 53). plan.src_volume is set where the source
mesh is still at hand (ui, RebuildBody) so the table can quote
body/corrected ratios.

Also fixes a pre-existing latent shadowing: the hole property loop and
the cone/sphere/torus loops rebounded build_body's name parameter, which
the report now prints -- the loop variable is renamed and the body name
captured before any loop.

Tests: 14 new headless tests (ledger merge rules, attribution, row
invariants over the corpus plate and the issue-#5 bracket, formatter);
the FreeCAD smoke gains two feature-report checks. Docs: ROADMAP phase
3 status, VERIFY section 6, design-notes 53, README capability bullet.
@MasoudMiM
MasoudMiM merged commit a705c30 into main Nov 9, 2026
4 checks passed
@MasoudMiM
MasoudMiM deleted the feature/deviation-report branch November 9, 2026 03:07
MasoudMiM added a commit that referenced this pull request Nov 9, 2026
Per-feature deviation report merged to main from
feature/deviation-report (PR #15); the status line still said 'in
development' with the branch name. Mark it done, ships-in-next-release,
matching the Phase 1/2 phrasing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant