Repository navigation
Fix installer doing nothing when run through a symlink - #1
Merged
Merged
Conversation
Comparing the raw argv path against import.meta.url fails when the script runs through a symlink, which is how npx and node_modules/.bin invoke it on macOS and Linux. The installer exited silently there. Bump to 1.0.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer checked whether it was the entrypoint by comparing argv[1] to its own path without resolving symlinks. npx and node_modules/.bin run it through a symlink on macOS and Linux, so it exited without doing anything. This is also why the macOS CI jobs failed in pack smoke. Restores the realpath check that 1.0.0 dropped and bumps to 1.0.1.