feat: support rendering diff previews for files outside current workspace - #40
Open
edahlseng wants to merge 1 commit into
Open
feat: support rendering diff previews for files outside current workspace#40edahlseng wants to merge 1 commit into
edahlseng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
allowExternalDiffPreviewsconfiguration option, enablingeditandwritetool diff previews for files located outside the active workspace directory when explicitly enabled by the user.Key Changes
src/types.ts&src/config-store.ts: AddedallowExternalDiffPreviewsboolean configuration property (defaults tofalse).src/pending-diff-preview.ts: AddedReadWorkspaceOptionsparameter toreadWorkspaceUtf8File,resolveWorkspaceReadPath,buildPendingWritePreviewData, andbuildPendingEditPreviewDatato conditionally allow external path previews.src/tool-overrides.ts: Passed current config option to diff preview builders duringeditandwritedisplay calls and write execution content capture.src/config-modal.ts: Added configuration modal setting with inspector details and off/on toggles.src/presets.ts: UpdatedconfigsEqualcheck.README.mdandconfig/config.example.json.tests/tool-ui-utils.test.tsverifying blocked behavior whenfalseand successful diff generation whentrue.Related Issue
Closes #39
Testing
Ran unit tests via
npx tsx --test tests/tool-ui-utils.test.tsto verify both default blocked and enabled behavior.