Skip to content

Add production-ready Multiple Accounts support - #136

Open
Mat4m0 wants to merge 22 commits into
mainfrom
feature/multiple-accounts
Open

Add production-ready Multiple Accounts support#136
Mat4m0 wants to merge 22 commits into
mainfrom
feature/multiple-accounts

Conversation

@Mat4m0

@Mat4m0 Mat4m0 commented Aug 13, 2026

Copy link
Copy Markdown
Owner

What changed

  • adds an explicit Single Account / Multiple Accounts mode with isolated persistent sessions, profile-scoped Keychain entries, window state, templates, and build libraries
  • adds the focused Multiple Accounts Hub with static Reforged artwork, native macOS interaction patterns, account creation/editing, archive recovery, and mode management
  • launches selected accounts independently with inactive window creation, deterministic cascade placement, first-selected final focus, and honest per-account progress
  • adds profile-safe renderer recovery, bounded launch issue codes, per-account Retry, and partial-batch failure handling
  • preserves the existing Single Account workspace and supports explicit one-way imports without linking or synchronizing the two modes
  • documents the ownership boundary and final visual system

Why

Players want to run several Guild Wars accounts without cloning the application or risking their existing login, templates, builds, and game files. The previous single-window architecture also made focus behavior, crash recovery, and data ownership ambiguous once more than one renderer existed.

This change gives every game window an immutable account context while keeping the verified client and updater shared. The Hub stays a focused launch surface; destructive management and mode switching remain one level deeper in Settings.

Player impact

  • Single Account remains the default and is unchanged until Multiple Accounts is explicitly enabled.
  • Each Multiple Accounts account signs in separately and keeps private browser/game storage and credentials.
  • Builds and in-game templates may be shared only within the Multiple Accounts workspace or kept separate per account.
  • Successful batches focus the first selected account. Partial failures leave successful accounts running and keep the Hub visible for recovery.

Validation

  • pnpm check
  • pnpm build
  • 1,011 unit tests
  • 163 policy tests
  • 71 tools tests
  • 40 integration tests
  • 21 release tests
  • 31 tools E2E tests
  • full Electron suite: 114 passed, 1 intentionally skipped
  • pnpm verify
  • packaged application smoke test
  • packaged Enhancement runtime smoke test
  • bounded desktop and 640×560 compact visual QA
  • Impeccable detector: zero findings

@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
gwonmac-website Ready Ready Preview Aug 13, 2026 8:47am

Request Review

@Mat4m0
Mat4m0 marked this pull request as ready for review August 13, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant