Fix bwk - #11
Merged
Merged
Conversation
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the numerical stability and correctness of the backward (gradient) computations for Pfaffian-related strategies, especially in the presence of singular or ill-conditioned matrices. The main changes ensure that the backward passes avoid using numerically unstable pseudo-inverses, compute correct gradients for singular cases, and include robust test coverage for these scenarios.
Numerical stability and correctness improvements:
PfaffianBlockDetandPfaffianFDBPfnow usetorch.linalg.inv(LU factorization) instead oftorch.linalg.pinv(SVD) to compute matrix inverses, avoiding convergence issues on ill-conditioned inputs. For singular matrices, the code replaces them with the identity matrix before inversion and computes the correct gradient using the cofactor (adjugate) matrix where necessary. [1] [2] [3]Algorithmic and implementation refinements:
_cofactor_matrixis introduced inPfaffianBlockDetto compute the cofactor matrix for singular blocks, ensuring gradients are finite and correct.Expanded and improved test coverage:
These changes collectively make the Pfaffian strategies more robust and reliable for a wider range of input matrices.
Checklist
Please complete the following checklist when submitting a PR. The PR will not be reviewed until all items are checked.
Make sure that the tests passed and the coverage is
sufficient by running
uv run pytest --session-timeout=600.You can do this by running
uvx pre-commit run --all-files.You can do this by running
uv run mypy src tests.