Iceberg docs two llms sequential #34787
Closed
+758
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add substantive improvements to Iceberg sink documentation: - Clarify that KEY is required (not optional) for Iceberg sinks - Add REST catalog example as alternative to S3 Tables - Expand progress tracking section with resume behavior details - Expand table creation section with field ID and schema evolution notes - Add monitoring section with mz_iceberg_sinks query examples - Clarify nested type limitations in the limitations section Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add polish and operational guidance to Iceberg sink documentation: - Specify exact S3 Tables IAM permissions instead of wildcard - Add type mapping notes for precision limits and serialization - Add real-world considerations for commit intervals (query engine overhead, compaction strategy) These changes provide better operational guidance for production use. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
Author
|
Served its purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually reconciling two different LLM outputs is hard, since the language will vary in non-material ways. (See the diffs between #34781 and #34784 here).
Here we try a different approach: Take the output of #34781 and ask for focused edit proposals. The LLM chose to break out its results into:
High priority (technical correctness) (diffs)
Medium priority (improve understanding): (diffs)
5. Expand progress tracking/resume behavior
6. Expand table creation behavior
7. Add monitoring section
8. Clarify nested type limitations
Low priority (polish): (diffs)
9. Add more specific IAM permissions
10. Add type mapping notes
11. Add commit interval real-world considerations
Prompt used:
you are an experienced technical documentation author.
look at the proposed docs for Iceberg on this branch and critique them/make suggestions for improvements.
focus on substantive content changes, not style. we want the diff to be as small as possible while making
the improvements you feel are important. look at the code and design docs in this repo as much as you want.