Open
Conversation
a1969c9 to
b13ece6
Compare
Contributor
|
The Postgres CDC CI fail is from #34892 first commit, which I've now fixed in the second commit of that PR. |
ggevay
approved these changes
Feb 3, 2026
Contributor
ggevay
left a comment
There was a problem hiding this comment.
Thank you! It seems it's very effective at finding issues!
Contributor
Author
|
Yep, I'll just wait until your PR is merged before merging this! |
Contributor
Author
Mostly not the kinds of issues it was trying to find though! Only a select few correctness issues. The panics were mostly found because it seems to have a worse idea of types than SQLsmith/parallel-workload currently and also has some extra syntax. |
1727a37 to
47b8ebf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on Gabor's PR #34892. I'll rebase with only the second commit after it's been merged.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.