[persist] Fix a futurelock in the recent update lease attempt#34980
Open
bkirwi wants to merge 4 commits intoMaterializeInc:mainfrom
Open
[persist] Fix a futurelock in the recent update lease attempt#34980bkirwi wants to merge 4 commits intoMaterializeInc:mainfrom
bkirwi wants to merge 4 commits intoMaterializeInc:mainfrom
Conversation
Contributor
Author
|
There's a mysterious Kafka failure in the nightlies that I want to investigate, but otherwise this is probably ready for a look. |
…time#34875 (MaterializeInc#34937)" This reverts commit 664cdf5.
bkirwi
force-pushed
the
task-lease-fix
branch
from
e83ea3b to
d11ce86
Compare
bkirwi
force-pushed
the
task-lease-fix
branch
from
d11ce86 to
bc60a0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This un-reverts a recent buggy change, adds some supporting code and a reproducer for the bug, then reimplements it hopefully-more-correctly in the last commit.
Motivation
Fixes https://github.com/MaterializeInc/database-issues/issues/10081.
Tips for reviewer
This was an instance of futurelock.
Perhaps it's hubristic to try and fix a bug in a recent concurrency abstraction I landed by using another recent concurrency abstraction I landed? I think the semantics are right - fundamentally the only safe thing to do is wake all waiters, and try and make it not too expensive - but I am open to suggestions.