Repository navigation
Conversation
radar_display.cpp and runway_overlay.cpp each held a private copy of
offsetKmFromCenter, latLonToScreen, distSqFromCenter and
clipPointToOuterRing, plus their own kKmPerDeg/kDegToRad. Move them into
ui/radar_projection.{h,cpp} and drop the duplicates. No behavior change.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017qjXYQiTkbgyVV7ZzvKzA3
MatixYo
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
radar_display.cppandrunway_overlay.cppeach carried their own private copy of the same four functions —offsetKmFromCenter,latLonToScreen,distSqFromCenter,clipPointToOuterRing— plus their ownkKmPerDegandkDegToRad. Identical code, two places to keep in sync: thecos(latitude)longitude-scaling fix had to be applied twice, and the next projection change would too.Moved them into a new
ui::radartranslation unit (include/ui/radar_projection.h+src/ui/radar_projection.cpp) and removed both copies. The constants now exist once.Pure refactor: same math, same call sites, no behavior change. User impact: none visible; the point is that aircraft and runway overlays can no longer drift apart in how they map lat/lon to the screen.
Tested: builds for env:supermini; ran on an ESP32-C3 Super Mini + GC9A01 (combined with other local changes).
🤖 Generated with Claude Code
https://claude.ai/code/session_017qjXYQiTkbgyVV7ZzvKzA3