Repository navigation
Re-render the portal form after saving its settings - #99
Merged
MatixYo merged 1 commit intoSep 30, 2026
Merged
Conversation
- saving in the Wi-Fi portal persisted the new values but left the form showing the old ones, so settings appeared to revert at random - checked/selected markers are not read from state at render time - so we must rebuild the strings at the end of the save callback so the next render reflects what was actually stored Also renames refreshPortalParamDefaults to refreshPortalParamValues. These are not defaults -- they are the stored settings, re-seeded into the parameters WiFiManager owns, and calling them defaults invites the reading that they only apply before anything is saved, which is the bug above. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also renames refreshPortalParamDefaults to refreshPortalParamValues. These are not defaults -- they are the stored settings, re-seeded into the parameters WiFiManager owns, and calling them defaults invites the reading that they only apply before anything is saved, which is the bug above.