Development#1
Open
MatrikSer wants to merge 29 commits into
Open
Conversation
…into development
12gerts
reviewed
Oct 13, 2025
| @@ -0,0 +1,29 @@ | |||
| CREATE TABLE IF NOT EXISTS visit_stats ( | |||
Collaborator
There was a problem hiding this comment.
зачем так? почему не через orm?
| таблицы visit_stats, visit_uniques, visit_all, триггеры update_unique_after_insert | ||
| и update_total_after_insert. | ||
| """ | ||
| schema_path = os.path.join(os.path.dirname(__file__), '..', 'data', 'schema_for_create_db.sql') |
Collaborator
There was a problem hiding this comment.
через pathlib вся работа с файлами
| """ | ||
| Создает html-страницу со статистикой посещений, основываясь на переданных данных. | ||
| """ | ||
| html = """ |
Collaborator
There was a problem hiding this comment.
а вот это наоборот надо унести в html файл и использовать шаблоны
| """ | ||
| Возвращает строку с информацией о периоде, основываясь на данных из БД. | ||
| """ | ||
| if row[0] == 'all': |
Collaborator
There was a problem hiding this comment.
- Мне не нравятся индексы, лучше использовать модель. Например,pydantic прекрасно с БД справляется
- Мб тут лучше match case?
Comment on lines
+19
to
+24
| def test_insert_visit_data_db_error() -> None: | ||
| pass | ||
|
|
||
|
|
||
| def test_insert_visit_data_unknown_error() -> None: | ||
| pass |
| def test_insert_visit_data_success() -> None: | ||
| test_db_path = os.path.join(os.path.dirname(__file__), '..', 'data', 'test_visits.db') | ||
|
|
||
| with patch('insert_visit_data.os.path.join') as mock_join: |
Collaborator
There was a problem hiding this comment.
давай как на паре через фикстуры
| request.cookies = {} | ||
| request.remote = None | ||
|
|
||
| with patch('handlers.insert_visit_data.insert_visit_data') as mock_insert: |
| request.cookies = {'user_hash': existing_hash} | ||
| request.remote = '192.168.1.100' | ||
|
|
||
| with patch('handlers.insert_visit_data.insert_visit_data') as mock_insert: |
Collaborator
There was a problem hiding this comment.
везде, дальше писать не буду
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.