Development#1
Open
MatrikSer wants to merge 10 commits into
Open
Conversation
12gerts
reviewed
Oct 4, 2025
| from http_client.structures import Request, Url_info | ||
|
|
||
|
|
||
| class Http_client: |
There was a problem hiding this comment.
Suggested change
| class Http_client: | |
| class HttpСlient: |
There was a problem hiding this comment.
Блин, чет мне не очень нравится такое архитектурное решение: что у тебя этот клиент и контекстный менеджер, и основной обработчик, ладно бы у тебя все действие внутри происходило. Мб лучше принимать как параметр при создании объекта коннект?
Comment on lines
+19
to
+23
| self.timeout: int = timeout | ||
| self.socket: socket.socket | None = None | ||
| self.ssl_socket: ssl.SSLSocket | None = None | ||
| self.response: bytes | None = None | ||
| self.response_body: bytes | None = None |
| from typing import NamedTuple | ||
|
|
||
|
|
||
| class Args(NamedTuple): |
There was a problem hiding this comment.
сделай BaseModel, тогда можно будет задать дефотл для таймаута и добавить валидатор прям внутрь класса
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.