Repository navigation
CI: attach firmware on any published release - #7
Merged
Mattboxx merged 1 commit intoNov 1, 2026
Merged
Conversation
The release job only ran on "v*" tags, so a release published from the GitHub UI with tag "2.0.0" did nothing. - Triggered by "release: published" (any tag name) instead of tag pushes. - Manual run with a "tag" input builds that tag and attaches the files to the existing release (used to fix 2.0.0). - Attaches the committed firmware/ files of the tag - the exact binaries the web installer serves and that were tested - after checking them against manifest.json, and only if the build + tests job passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XDVAmsBNuEdJfETCBknBj6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release job only ran on tags starting with
v. Release2.0.0was published from the GitHub UI with tag2.0.0, so no workflow started and the release has no files.Fix
release: published, whatever the tag name.tag) builds that tag and attaches the files to an existing release. I'll use it right after merging to fix2.0.0.firmware/files of the tag: the exact binaries the web installer serves and that were tested on the ESP32-S3. CI rebuilds would not be byte-identical.manifest.json(size and SHA-256) before uploading.contents: write, and actions stay SHA-pinned.Generated by Claude Code