Use manage_options instead of edit_plugins capability - #14
Open
stevegrunwell wants to merge 3 commits into
Open
Conversation
Use the activate_plugins, not edit_plugins, capability for add_options_page() as the latter makes the plugin settings page inaccessible when DISALLOW_FILE_EDIT is enabled in wp-config.php
Instead of activate_plugins, use the much more sensible manage_options capability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the WordPress Codex, the
edit_pluginscapability is mostly used to determine whether Plugins > Plugin Editor is accessible. On sites that use wp-config.php constants likeDISALLOW_FILE_EDIT(for instance, all of my production sites), theedit_pluginscapability is deactivated, meaning I can't configure this plugin without enabling the plugin editor.This pull request changes the capability to the more sensible manage_options - if the user has the power to change the site title, permalink structure, and other much more destructive changes, they should be able to edit the Twitter configuration.