Repository navigation
Conversation
…ate queue.shift() Refactored `findWindowIdForFolder` to build and cache a complete map of `FolderId -> windowId` using a `WeakMap` bound to the `store` instance. This eliminates the $O(S \times N)$ space iteration nested inside other loops (like `findWindowIdForItem` which itself iterates over all $F$ folders), turning subsequent lookups into $O(1)$. Also replaced the $O(N)$ `queue.shift()` BFS implementation with a much faster $O(1)$ stack-based DFS traversal. Benchmark time dropped from ~400ms down to ~85ms. Co-authored-by: matuyuhi <92073990+matuyuhi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:
WeakMap<SpaceStore, Map<FolderId, number>>to cache the folder-to-windowId mapping for a givenstoreinstance.queue.shift()array method, to a stack-based Depth-First Search (DFS) which uses the much fasterstack.pop()array method.🎯 Why:
There was an explicit anti-pattern within
findWindowIdForFolder. It was doing a recursive BFS over every space root from scratch, and it lacked memoization. This function was being called recursively fromfindWindowIdForItemwhich itself iterated across the whole set of folders. This resulted in extreme scaling complexity whenever there was a large folder nesting depth and higher quantities of spaces.📊 Measured Improvement:
In a local benchmark modeling 100 spaces and 100 folders each iteratively:
findWindowIdForItemoriginal without memoization): ~397.45msfindWindowIdForItemWeakMap cache + stack DFS): ~84.22msPR created automatically by Jules for task 10734171062515578193 started by @Matuyuhi