Skip to content

🧪 Add tests for dispatchFetch in live sources - #82

Open
Matuyuhi wants to merge 1 commit into
mainfrom
testing-improvement-dispatch-fetch-3319829850808450412
Open

Matuyuhi wants to merge 1 commit into
mainfrom
testing-improvement-dispatch-fetch-3319829850808450412

Conversation

@Matuyuhi

Copy link
Copy Markdown
Owner

🎯 What:
Added a missing test file src/background/live/sources/index.test.ts to cover the dispatchFetch function's behavior, particularly its error path when an unknown or invalid LiveSource type is provided.

📊 Coverage:

  • Added test verifying that dispatchFetch throws correctly formatted error when no adapter is found for a given LiveSource type.
  • Added tests to cover happy paths (delegating to githubAdapter or rssAdapter appropriately based on the LiveSource type).

✨ Result:
The dispatchFetch function in src/background/live/sources/index.ts is now fully unit tested. The new suite passes and ensures no regressions when handling various source types.


PR created automatically by Jules for task 3319829850808450412 started by @Matuyuhi

…ources

Co-authored-by: matuyuhi <92073990+matuyuhi@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant