Skip to content

⚡ Optimize importChromeTabGroups to avoid N+1 queries #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Matuyuhi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize importChromeTabGroups to avoid N+1 queries #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions src/background/space-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,18 +724,29 @@ export async function addTabsToFolder(
export async function importChromeTabGroups(windowId: number): Promise<Space[]> {
const groups = await chrome.tabGroups.query({ windowId })
const created: Space[] = []
for (const g of groups) {
let groupTabs: chrome.tabs.Tab[]
try {
groupTabs = await chrome.tabs.query({ groupId: g.id })
} catch {
continue
}
const store = await loadStore()
const claimed = new Set<number>()
for (const f of Object.values(store.folders)) {
for (const it of f.items) if (it.kind === 'tab') claimed.add(it.tabId)

const allTabs = await chrome.tabs.query({ windowId })
const tabsByGroupId = new Map<number, chrome.tabs.Tab[]>()
for (const tab of allTabs) {
if (tab.groupId !== undefined && tab.groupId !== chrome.tabGroups.TAB_GROUP_ID_NONE) {
let groupTabs = tabsByGroupId.get(tab.groupId)
if (!groupTabs) {
groupTabs = []
tabsByGroupId.set(tab.groupId, groupTabs)
}
groupTabs.push(tab)
}
}

const store = await loadStore()
const claimed = new Set<number>()
for (const f of Object.values(store.folders)) {
for (const it of f.items) if (it.kind === 'tab') claimed.add(it.tabId)
}

for (const g of groups) {
const groupTabs = tabsByGroupId.get(g.id) || []

const tabIds = groupTabs
.map((t) => t.id)
.filter((id): id is number => typeof id === 'number' && !claimed.has(id))
Expand Down