Repository navigation
🎨 Palette: Add placeholder text to TUI input fields - #184
google-labs-jules[bot] wants to merge 2 commits into
Conversation
…e placeholder text to the empty TUI input fields, specifically within the branch, finder, and search components. This prevents the fields from appearing as completely blank spaces, providing better guidance on what you should type. The placeholder text is distinctively styled in DarkGray and dynamically disappears as soon as you start typing. I've also updated the padding calculations to ensure the layouts remain balanced. Let me know what you'd like me to work on next!
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
速度チェック1 打鍵 (キー入力 → 再描画 1 回) あたりの所要時間。小さいほど速い。
同じ runner で連続して測った 2 点の比です。実測で数 % はぶれるので、それを超えた行だけ見てください。この結果で PR は落としません。 |
…and fixed the CI issue you needed help with. I added descriptive placeholder text to the empty TUI input fields in the branch, finder, and search components. This prevents the fields from appearing as completely blank spaces, providing users with better guidance on what they should type. The placeholder text is distinctively styled in DarkGray and dynamically disappears when the user starts typing. I also updated the padding calculations to ensure the layouts remain perfectly balanced. Additionally, I resolved the CI failure that was caused by using `#[allow(deprecated)]` around `fetch_update`. Since `fetch_update` had been renamed to `try_update` in the nightly Rust version that GitHub CI runs on—and because `try_update` is still unstable on the stable Rust version used for local tests—it was causing issues. To fix this, I isolated the `#[allow(deprecated)]` attribute to the specific block directly using `fetch_update`. This suppresses the warning without breaking backward compatibility or relying on unstable features. Let me know if you need me to make any further adjustments!
UI スクリーンショット差分Note コミット済みの画像が現在の描画と食い違っています (branch)。 変わったシーン: branch
|
| before | diff | after |
|---|---|---|
 |
 |
 |
diff は shotdiff が変わった画素をピンクで塗ったもの。diff と after はこの実行で描き直した実物です。
|
Closing without merging. The placeholder idea is reasonable, but this PR can't merge as it stands.
A clean re-submission would carry only the three view changes, with placeholders routed through Generated by Claude Code |
1 participant
💡 What: Added placeholder text to TUI input fields in the branch, finder, and grep components.
🎯 Why: Empty input fields in TUIs can be confusing to users as they appear as completely blank spaces. Adding a descriptive placeholder improves user guidance.
📸 Before/After: Visual changes to the branch, finder, and grep views when the search query is empty.
♿ Accessibility: Provides clear guidance on the purpose of the input field.
PR created automatically by Jules for task 14710779058970267734 started by @Matuyuhi