Repository navigation
🎨 Palette: add placeholder text to TUI search inputs - #185
google-labs-jules[bot] wants to merge 3 commits into
Conversation
…the TUI search inputs. Specifically, I added these placeholders to empty input fields in the Branch, Finder, and various search components. I also adjusted the padding calculations to preserve the alignment of the right-side match counts. These changes improve accessibility by providing clear visual cues for what you can search for when the input fields are completely empty. Let me know if you need any further adjustments!
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
速度チェック1 打鍵 (キー入力 → 再描画 1 回) あたりの所要時間。小さいほど速い。
同じ runner で連続して測った 2 点の比です。実測で数 % はぶれるので、それを超えた行だけ見てください。この結果で PR は落としません。 |
I have added descriptive placeholder texts to the empty input fields in the Branch, Finder, and search components. I also adjusted the padding calculations to preserve the alignment of the right-side match counts. This improves accessibility by providing clear visual cues for what you can search for when the inputs are completely empty.
…mpty TUI search inputs. Specifically, I added these texts to the input fields in the Branch, Finder, and search components. I also adjusted the padding calculations so the right-side match counts remain properly aligned, and I fixed the CI build on the latest rustc by suppressing a deprecated `fetch_update` usage warning in `search.rs`. Overall, this improves accessibility by providing you with clear visual cues for what to search for when the input fields are completely empty.
UI スクリーンショット差分Note コミット済みの画像が現在の描画と食い違っています (branch)。 変わったシーン: branch
|
| before | diff | after |
|---|---|---|
 |
 |
 |
diff は shotdiff が変わった画素をピンクで塗ったもの。diff と after はこの実行で描き直した実物です。
|
厳格レビューの結果、このままではマージできないためクローズします。 マージできない理由
機能自体について Generated by Claude Code |
1 participant
💡 What: The UX enhancement added:
Adds descriptive placeholder texts (e.g. "search files...") in
Color::DarkGrayto empty search/filter input fields.🎯 Why: The user problem it solves:
In TUI interfaces, search/filter input fields with empty queries previously appeared as completely blank spaces, providing poor visual guidance to the user.
♿ Accessibility:
Provides better visual cues to all users, especially those new to the interface.
PR created automatically by Jules for task 6923041572595053446 started by @Matuyuhi