Repository navigation
🎨 Palette: Add placeholders to empty input fields - #187
google-labs-jules[bot] wants to merge 1 commit into
Conversation
…lds.
Previously, empty inputs in the Finder and workspace search lacked visual guidance, appearing only as a lone cursor. To improve discoverability, I added descriptive, dark-gray placeholder text ("type to filter" and "search workspace" respectively) that appears when the search query is empty.
Additionally, for the Finder, I updated the manual padding calculation that keeps the match count right-aligned so it now correctly accounts for the width of the new placeholder text. Let me know if you need any further adjustments!
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
速度チェック1 打鍵 (キー入力 → 再描画 1 回) あたりの所要時間。小さいほど速い。
同じ runner で連続して測った 2 点の比です。実測で数 % はぶれるので、それを超えた行だけ見てください。この結果で PR は落としません。 |
|
Closing this PR for now instead of merging it. The idea (placeholders in the Finder and Grep inputs) is reasonable, but it isn't mergeable as it stands:
A resubmission should add the strings to Generated by Claude Code |
🎨 Palette: Add placeholders to empty input fields
💡 What
Added distinct placeholder text to the empty search input fields in the Finder (
Ctrl+p) and Grep (Ctrl+f) TUI components. The text is styled withColor::DarkGrayto indicate it is a placeholder.🎯 Why
Empty input fields in the TUI environment can be confusing because they only render a lone cursor or blank space. The placeholders explicitly tell the user what the input field is for ("type to filter" for Finder, "search workspace" for Grep), improving overall discoverability and usability.
♿ Accessibility
The placeholders improve cognitive accessibility by explicitly labeling the purpose of the input fields dynamically. The color contrast uses standard
Color::DarkGrayto distinguish it from actual input.Screenshots (Before/After equivalent context)
Before:
> █After:
> █type to filter(in Finder)> █search workspace(in Grep)PR created automatically by Jules for task 2368805791664604683 started by @Matuyuhi