Repository navigation
🎨 Palette: Add placeholders to empty input fields - #188
Conversation
… 🎨 Palette to add placeholders to empty input fields. I added styled placeholders (like "type to filter..." and "type to search...") to the input areas of the finder, branch, and text search panels when their queries are empty. This resolves a UX issue where empty text inputs looked like completely blank spaces, giving you clear context on what actions you can take. This change also dynamically calculates layout padding based on whether the placeholder text is visible to maintain accurate alignment of the result counts on the right. Lastly, I've included two new UI preview scenes so you can easily test the empty input states. Let me know if you need anything else!
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
速度チェック1 打鍵 (キー入力 → 再描画 1 回) あたりの所要時間。小さいほど速い。
同じ runner で連続して測った 2 点の比です。実測で数 % はぶれるので、それを超えた行だけ見てください。この結果で PR は落としません。 |
I added styled placeholders ("type to filter..." / "type to search...") to the input areas of the finder, branch, and search panels when their queries are empty. This addresses a UX issue where empty text inputs look like completely blank spaces, giving you clearer context on what actions you can take.
I also made sure this change dynamically calculates layout padding based on whether the placeholder text is visible in order to maintain accurate alignment of the result counts on the right. Additionally, I have included two new UI preview scenes so you can easily test the empty input states, and I replaced a deprecated atomic method.
UI スクリーンショット差分Note コミット済みの画像が現在の描画と食い違っています (branch finder_empty grep_empty)。 変わったシーン: branch, finder_empty, grep_empty
|
| before | diff | after |
|---|---|---|
 |
 |
 |
finder_empty
| before | diff | after |
|---|---|---|
| (新規) | — |  |
grep_empty
| before | diff | after |
|---|---|---|
| (新規) | — |  |
diff は shotdiff が変わった画素をピンクで塗ったもの。diff と after はこの実行で描き直した実物です。
|
Merging this PR. Decision notes:
Generated by Claude Code |
1 participant
💡 What: Added descriptive placeholder text (e.g. "type to filter..." and "type to search...") styled in
Color::DarkGrayto thefinder,branch, andgrepinput fields when their queries are empty. Also updated padding calculation logic to ensure proper layout alignment when placeholders are visible, and added preview scenes for testing the empty query states.🎯 Why: When a search or filter input is empty in a TUI, it appears as a completely blank line. This leaves users without clear guidance on what action to take or what the input field is used for. Adding placeholders immediately provides context on how to interact with the current view.
📸 Before/After:
Before:
> ▎ 8/8After:
> ▎type to filter... 8/8♿ Accessibility: Improves cognitive accessibility by explicitly labeling the purpose of an otherwise blank text input area.
(Also added a journal entry in
.Jules/palette.mdnoting the importance of descriptive placeholders in TUI input fields).PR created automatically by Jules for task 8176794115079853107 started by @Matuyuhi