Skip to content

🎨 Palette: Add placeholders to input fields in status bar - #189

Closed
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette-ux-input-placeholders-11717160915141056616
Closed

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette-ux-input-placeholders-11717160915141056616

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🎨 Palette: Add placeholders to input fields in status bar

💡 What: Added descriptive placeholders (e.g. "type to search...", "type to filter...") to the global TUI input line located in the status bar when the user hasn't typed anything yet.
🎯 Why: Makes the purpose of the input fields immediately clear instead of relying on the user understanding short prefixes (like / or :), which improves discoverability and UX for both new and existing users.
♿ Accessibility: Reduces cognitive load and ensures users don't get stuck in a mode without knowing what input is expected.


PR created automatically by Jules for task 11717160915141056616 started by @Matuyuhi

💡 What: Added descriptive placeholders (e.g. "type to search...", "type to filter...") to the global TUI input line located in the status bar when the user hasn't typed anything yet.
🎯 Why: Makes the purpose of the input fields immediately clear instead of relying on the user understanding short prefixes (like `/` or `:`), which improves discoverability and UX for both new and existing users.
♿ Accessibility: Reduces cognitive load and ensures users don't get stuck in a mode without knowing what input is expected.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown
Contributor

UI スクリーンショット差分

Note

コミット済みの画像が現在の描画と食い違っています (branch finder_empty grep_empty)。
cargo preview --update-snapshots で更新してコミットしてください
(忘れたまま merge しても、main 側で自動的に追従コミットが積まれます)。

変わったシーン: branch, finder_empty, grep_empty

branch
before diff after
finder_empty
before diff after
(新規) —
grep_empty
before diff after
(新規) —

diff は shotdiff が変わった画素をピンクで塗ったもの。diff と after はこの実行で描き直した実物です。

github-actions Bot added a commit that referenced this pull request Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

速度チェック

1 打鍵 (キー入力 → 再描画 1 回) あたりの所要時間。小さいほど速い。

ケース ops base head 差分
open 1 8.513 ms 8.450 ms -0.7%
type 200 0.236 ms 0.237 ms +0.5%
scroll-down 300 0.302 ms 0.304 ms +0.4%
scroll-up 300 0.306 ms 0.307 ms +0.3%
search-type 9 1.152 ms 1.140 ms -1.0%
search-scroll 300 0.328 ms 0.328 ms +0.2%
type-tracked 200 0.267 ms 0.269 ms +0.5%
git-scroll 300 0.284 ms 0.288 ms +1.4%
git-scroll-side-wrap 300 0.313 ms 0.317 ms +1.4%

同じ runner で連続して測った 2 点の比です。実測で数 % はぶれるので、それを超えた行だけ見てください。この結果で PR は落としません。

Copy link
Copy Markdown
Owner

Closing this PR rather than merging it, for these reasons:

  1. It bypasses the UI language mechanism. The placeholders ("type to search...", "type line number...", etc.) are hard-coded English &'static str values. docs/design/ui-text.md requires user-visible text to go through lang::t(Msg::…), with variants added in msg.rs, ja.rs and en.rs. As written, Japanese users get English hints, and the previews, which are pinned to Japanese, would show the wrong language.
  2. The screenshot snapshots are stale. The CI screenshot-diff comment reports that docs/preview/*.svg no longer matches the render (branch, finder_empty, grep_empty). cargo preview --update-snapshots was not run and committed.
  3. The patch includes a log entry for an unrelated agent workflow. The .Jules/palette.md change is not part of the product.

The idea itself is reasonable. A redo should add Msg keys with both ja and en text, update the snapshots, and drop the .Jules file. CI itself (check, perf) was green.


Generated by Claude Code

@Matuyuhi Matuyuhi closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant