fix: assign result of .upper() in _next_letter and remove unused imports#1
Merged
MaxAnderson95 merged 2 commits intomainfrom Mar 20, 2026
Merged
fix: assign result of .upper() in _next_letter and remove unused imports#1MaxAnderson95 merged 2 commits intomainfrom
MaxAnderson95 merged 2 commits intomainfrom
Conversation
_next_letter discarded the return value of str.upper(), which would produce incorrect results for lowercase input. Also removed unused imports (math.e in rotor.py, re in reflector.py).
Adds 43 fuzz tests covering rotor bijectivity, reflector involution, plugboard invariants, machine reciprocal encryption, and edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnigmaMachine._next_letter()whereletter.upper()was called but the result was never assigned back, making it a no-op. Lowercase input (e.g.'z') would produce'{'instead of'A'.from math import einrotor.py.import reinreflector.py.hypothesisthat verify core cryptographic invariants: rotor bijectivity, reflector involution, plugboard symmetry, and the machine's reciprocal encryption property across thousands of randomized configurations.