Implement rank catchup system | Improve Help command#35
Open
jmarmstrong1207 wants to merge 9 commits intoMaxWasUnavailable:feature/dedicated_reworkfrom
Open
Implement rank catchup system | Improve Help command#35jmarmstrong1207 wants to merge 9 commits intoMaxWasUnavailable:feature/dedicated_reworkfrom
jmarmstrong1207 wants to merge 9 commits intoMaxWasUnavailable:feature/dedicated_reworkfrom
Conversation
jmarmstrong1207
changed the title
jmarmstrong1207
changed the title
Author
|
Also for help command: it currently doesn't send command.Usage. Added commit so that it tells you how exactly to use it |
jmarmstrong1207
force-pushed
the
catchup-rank
branch
from
3f2a5de to
64f92e5
Compare
MaxWasUnavailable
requested changes
Jan 31, 2026
| internal static void OnPlayerJoined(Player e) | ||
| { | ||
| PlayerJoined?.Invoke(e); | ||
| if (NucleiConfig.RankCatchUp!.Value) RankCatchUpService.CatchUpPlayer(e); |
There was a problem hiding this comment.
Should never perform functionality in the events. Should instead subscribe to the event somewhere and trigger through that.
The event invocations should be isolated like that.
Author
There was a problem hiding this comment.
Could you edit the file to show me? I'm unfamiliar with doing this myself
Owner
There was a problem hiding this comment.
You'd subscribe to the PlayerJoined event and run a method on that, see Nuclei.cs for an example of this.
# Conflicts: # Nuclei/Features/NucleiConfig.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #28
This is simple. As mission time passes, players that join will get a head start in rank and funds based on the % of max mission time.
Help command now doesn't cut out due to char limit
TODO: Be able to toggle via config file - ✅ Done
View https://github.com/jmarmstrong1207/Nuclei/tree/merge-test branch for implementation of all these PRs