Repository navigation
fix: data safety from the code review (paste into itself, Ctrl+S mid-switch, atomic saves), 0.117.2 - #414
Merged
Conversation
…s before it makes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
…ng across a rename or move Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
… new, and a slow save keeps later typing dirty Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
…s the viewer back to a file left behind Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
…e CI runner does not fail the in-place case Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data-safety fixes from the 2026-10-16 code review (
research/prism/2026-10-16-code-review.md, findings #1, 2, 15, 18, 19, 8, 30). Built by an Opus agent and reviewed by a second.Fixes
copyCountednow lists before it creates the target. (pasteCopy.ts)save()only writes when the editor is showing that path, and writes to the path its saved state belongs to. It used to write the previous file's text over the new file. The same guard keeps typing in the still-shown old document from being filed under the next file. (codeSave.ts,CodeView.tsx)textFile.ts)replaceFile.ts)Behaviour changes to know:
Tests
pasteCopy.test.ts,codeSave.test.ts,textFile.test.ts,replaceFile.test.ts,useFileOps.test.ts. 258 files pass; typecheck clean, lint 0 errors.themeWall(frame timing) andzipPreviewBack(both on the known-flaky list) passed on an immediate rerun.0.117.2.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx