Skip to content

fix: data safety from the code review (paste into itself, Ctrl+S mid-switch, atomic saves), 0.117.2 - #414

Merged
Maxaubert merged 6 commits into
mainfrom
fix/review-data-safety
Oct 16, 2026
Merged

Maxaubert merged 6 commits into
mainfrom
fix/review-data-safety

Conversation

@Maxaubert

Copy link
Copy Markdown
Owner

Data-safety fixes from the 2026-10-16 code review (research/prism/2026-10-16-code-review.md, findings #1, 2, 15, 18, 19, 8, 30). Built by an Opus agent and reviewed by a second.

Fixes

Behaviour changes to know:

  • Deleting the film that is playing now moves to the next file paused; before, the next one played.
  • The tmp-and-rename save drops a file's hidden/system attributes, alternate data streams (Zone.Identifier) and hard links, as every atomic save on Windows does. The ACL is inherited from the folder.

Tests

  • New unit tests: pasteCopy.test.ts, codeSave.test.ts, textFile.test.ts, replaceFile.test.ts, useFileOps.test.ts. 258 files pass; typecheck clean, lint 0 errors.
  • Full e2e: 126 of 128 passed. themeWall (frame timing) and zipPreviewBack (both on the known-flaky list) passed on an immediate rerun.

0.117.2.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx

Maxaubert and others added 6 commits October 16, 2026 08:09
…s before it makes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
…ng across a rename or move

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
… new, and a slow save keeps later typing dirty

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
…s the viewer back to a file left behind

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
…e CI runner does not fail the in-place case

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
@Maxaubert
Maxaubert merged commit ab491a6 into main Oct 16, 2026
3 checks passed
@Maxaubert
Maxaubert deleted the fix/review-data-safety branch October 16, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant