Repository navigation
perf: a smooth Explorer from the code review (scroll, search, sidebar drag), 0.117.4 - #417
Merged
Merged
Conversation
…on release Every pointer move set the width state (re-rendering the whole Sidebar) and wrote the pref. A move now paints the clamped width onto the panel, its body and the separator's aria value; the release keeps it once, the Explorer grips' rule (useExplorerWidths). createPanelDrag is pure and tested. Review finding 22, 2026-10-16. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
… focus Finding 3: every native scroll event patched the tab, re-rendering the whole App, re-sorting the folder (useFolderSizes handed back a fresh object every render) and the viewer's files (the view memo was keyed on the tab), and sending every tab's history to main. BrowseList now keeps its live scroll and hands it up when it settles (lib/scrollSettle.ts) or at once for a key's move, to the history entry it was made in (setBrowseScroll), so Back still finds it. useFolderSizes memoizes its answer; App's view memo is keyed on active.files. Finding 7: the search key carried `revision`, which the window's focus and the folder's watcher bump, so coming back to Prism blanked the results, reset the window and restarted the walk. Only refreshKey (F5, a file operation) re-runs a search now. Review findings 3 and 7, 2026-10-16. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
Maxaubert
force-pushed
the
fix/review-smooth-explorer
branch
from
October 16, 2026 07:22
7de2a27 to
779036a
Compare
Maxaubert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoothness fixes from the 2026-10-16 code review (
research/prism/2026-10-16-code-review.md, findings #3, 7, 22). Built by an Opus agent and reviewed by a second.Fixes
Tests
extractWindowfailed once on a disk check (whether the extracted folder existed) and passed twice alone. It joins the flaky list; this branch does not touch extraction.0.117.3.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx