Repository navigation
fix: question follower reads the live screen and the last widget frame (core 0.41.5) - #242
Merged
Merged
Conversation
…frame questionWatch read only the viewport and extractQuestion took the first tab row, so a widget taller than the pane (tab row in scrollback) was never seen, a scrolled-up viewport read old scrollback, and a stale frame left above by a resize froze the follower on that question. It now reads from the buffer's baseY plus a screen of scrollback above, and the last tab row is the live widget (findLastIndex). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cnwwWNiEmM5ghBD933h59
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cnwwWNiEmM5ghBD933h59
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
…e (core 0.41.5) (#242) * fix: the question follower reads the live screen and the last widget frame questionWatch read only the viewport and extractQuestion took the first tab row, so a widget taller than the pane (tab row in scrollback) was never seen, a scrolled-up viewport read old scrollback, and a stale frame left above by a resize froze the follower on that question. It now reads from the buffer's baseY plus a screen of scrollback above, and the last tab row is the live widget (findLastIndex). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cnwwWNiEmM5ghBD933h59 * chore: bump core 0.41.5, app 0.55.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cnwwWNiEmM5ghBD933h59 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #236: the finding #24 fix (a6bbe28) was pushed to the branch after #236 merged, so it never reached main. Cherry-picked cleanly onto main.
questionWatchreads from the buffer'sbaseYplus one screen of scrollback above, not the viewport, so a widget taller than the pane is seen and a scrolled-up viewport no longer reads old scrollback.extractQuestionuses the last tab row (findLastIndex), so a stale frame left above by a resize no longer freezes the follower on an old question.questionWatch.test.tsandquestionWidget.test.ts(4 fail against main's code, pass with the fix).Checks:
npm test166 files / 2229 tests pass,npm run typecheckclean,npm run lint0 errors (12 existing warnings). e2e not run.🤖 Generated with Claude Code
https://claude.ai/code/session_014cnwwWNiEmM5ghBD933h59