Skip to content

refactor: dead code removal (review batch 8) - #408

Merged
Maxaubert merged 1 commit into
mainfrom
refactor/406-dead-code-removal
Oct 10, 2026
Merged

Maxaubert merged 1 commit into
mainfrom
refactor/406-dead-code-removal

Conversation

@Maxaubert

@Maxaubert Maxaubert commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Closes #406

Fixed

  • 16: removed the dead WM_TIMER branch in WndProc, stale comments and the 02-tick-loop.md sentence (g_tick stays, hotkeys use it)
  • 18: removed write-only overstay flags; comment now says the first STUCK? line fires at 10 s, then every 5 s
  • 31: removed ComputeFixedPointOffset and its tests; NudgePointer lost its unused out-param
  • 41: CursorBlanker no longer copies 14 cursors it never used or freed; 07-cursor.md corrected
  • 42: removed write-only CursorSprite::lastTopmostMs_
  • 49: removed cookActive, setButtons, isZoomButton (docs updated to setButtonBinds)
  • 67: removed JavaBridge::loaded()
  • 75: removed LooksLikeJsonObject and its test
  • 120: removed SameRoundingCell and its test
  • 121: removed PlaceFlyout/DetectEdge/Edge/Placement.edge, FlyoutRefresh, LateCount, GainLearner::warmedUp and their tests; BindVerdictName moved into tests/test_keybind_rules.cpp (its only user)
  • 108: removed InstallState/CompareVersion/ClassifyInstall and their tests; ParseVersion stays (webview2_probe.h uses it); header comment and 01-overview.md row updated
  • 128: removed RenderModel::primed_

Skipped

  • 49 (dbgHookDbl only): it is incremented by the hook and logged in the stuck-hold diagnostic, so it is live

Tests

  • build.bat test: [doctest] test cases: 577 | 577 passed | 0 failed | 0 skipped
  • build.bat and build.bat config: built, exit 0, no errors

No version bump: bumped at merge time.

🤖 Generated with Claude Code

https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu

The branch is main plus exactly the combined test build's state after this PR
(conflicts with the PRs merged before it resolved as tested), version 0.24.18.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu
@Maxaubert
Maxaubert force-pushed the refactor/406-dead-code-removal branch from 18fa795 to f201b82 Compare October 10, 2026 02:55
@Maxaubert
Maxaubert merged commit 3f619bb into main Oct 10, 2026
1 check passed
@Maxaubert
Maxaubert deleted the refactor/406-dead-code-removal branch October 10, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead code removal (review batch 8)

1 participant