Repository navigation
fix(tdr): safety and TDR guard leftovers (review batch 1) - #418
Merged
Merged
Conversation
The branch is main plus exactly the combined test build's state after this PR (conflicts with the PRs merged before it resolved as tested), version 0.24.10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu
Maxaubert
force-pushed
the
fix/416-tdr-safety-leftovers
branch
from
October 10, 2026 02:13
745ece0 to
0d1041a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #416. Batch 1 of the 2026-10-09 review: safety and TDR guard leftovers.
Fixed
GetDeviceRemovedReasonon the idle render device (RenderEngine::pollDeviceRemoved), so a TDR is attributed inside the 30 s churny-backstop window. The backstop now runs once per loss.EnginePickInputs::renderLostforces picks to transform (unit tested). Recovery still retries on the 500 ms backoff (deferred to 1x if a transform session is live). Render-only builds keep the old skip-and-sleep path.ParseConfigfoldstxSamplingMode2..4 and any other value to 0 (keeps 1 and -1), so the MPO guard sees them as nearest. (There was no raw setter branch left to delete inmain.cpp; the pass-through is only the 0/1/-1 values now.)inputTransformAvailable_is cleared permanently only onERROR_ACCESS_DENIED; any other failed publish is re-armed from the UIAccess token probe at session end.NtQuerySystemInformation(SystemProcessInformation)so no handle to dwm.exe is opened. OS boot time is the fallback. Pure format and currency logic moved tosrc/mpo_boot_logic.hwithtests/test_mpo_boot.cpp. Checked on this machine: the read matchesWin32_Process.CreationDateof dwm.exe exactly.Skipped
transform_model.cppis not in the test build; covered by review only.mpo_boot.txtis treated as not current once, so the first launch after upgrade re-records the registry value as it stands then.Tests
build.bat test:[doctest] test cases: 606 | 606 passed | 0 failed | 0 skipped,assertions: 97638 | 97638 passed | 0 failedbuild.bat: exit 0build.bat config: exit 0build.bat uiaccessnot run (noui/orWIND_UIACCESSchanges). Not hardware-tested: a real TDR was not provoked.No version bump: bumped at merge time.
🤖 Generated with Claude Code
https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu