Repository navigation
feat(tray): Pin to taskbar keeps the Wind icon next to the clock - #437
Merged
Merged
Conversation
A Preferences toggle (trayPinned, default on) sets IsPromoted on WindTray's own entry under HKCU\Control Panel\NotifyIconSettings, matched by its module path (known-folder form expanded) and UID. WindTray applies it at start, after an Explorer restart and when the ini changes (folder watch, 300 ms debounce); a missing first-run entry retries for about 12 s. The key is a UI-only global, so it never reloads the magnifier or changes with a profile. Closes #436 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu
# Conflicts: # src/version.h # ui/src/settings-schema.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436
What
A Pin to taskbar toggle in Preferences (General card, on by default) keeps Wind's tray icon next to the clock instead of in the hidden icons overflow.
HKCU\Control Panel\NotifyIconSettings\<id>(IsPromoted). WindTray finds its own entry by its module path (known-folder{GUID}form expanded) and UID 1, and writesIsPromotedonly when it differs. Explorer applies it live.TaskbarCreated), and when the ini changes (folder watch, 300 ms debounce that cannot be starved). A first-run entry that does not exist yet is retried for about 12 s.trayPinnedis a UI-only global key: it never reloads the magnifier and never changes with a profile.src/tray_app/tray_pin.*(registry) andtray_pin_logic.cpp(pure matching, unit-tested). Docs: 01, 02, 08, 09.Tests
build.bat test: 607 passed, 0 failed (new path matching and profile carry-over tests).trayPinned, never shows as unsaved).build.batandbuild.bat configbuild clean. Sonnet built it, Opus reviewed it, and all of the review's findings were applied.trayPinned=0took the icon off the taskbar and=1put it back, each within 2 s (checked via UI Automation and the registry); a WindTray restart re-applied the pin after it was cleared.Version: 0.26.x -> 0.27.0 (feature). If #435 merges first this branch picks up its version line. Release unsigned as before.
🤖 Generated with Claude Code
https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu