Repository navigation
fix(ui): review findings: shortcuts during capture, armed bind focus, duplicate app list, legacy model (#495) - #501
Merged
Merged
Conversation
…e core (#495) The core runs any model other than render/transform/hybrid as hybrid, but the page kept the raw value, so the Engine select showed blank and the Auto-only per-window engine rows hid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TdjopXZfsUiesYxYLYHEdH
…dialog (#495) A hand-edited list with the same exe twice made the keyed each throw when Manage opened. Entries are now deduped case-insensitively (the core matches exe names that way), first spelling wins. Also adds a page test for the legacy model=magnify reading as Auto. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TdjopXZfsUiesYxYLYHEdH
…#495) Settings' window keydown ran Ctrl+Q, Ctrl+F and Escape before the capture saw the key, so binding Ctrl+Q quit Wind and Ctrl+F could never be recorded. Bindings and PanBinding now flag themselves as listening (lib/capture.js) and Settings skips its shortcuts while one is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TdjopXZfsUiesYxYLYHEdH
…#495) The armed mousedown handler called preventDefault on every press, refused ones included, so a plain click elsewhere kept the focus, the blur that cancels never fired and the cleared binding stayed cleared (or two rows were armed at once). A refused press away from the armed box now cancels and goes through; on the box itself it still stays armed with the refusal. Bindings and the onboarding KeybindCapture also cancel when unmounted while armed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TdjopXZfsUiesYxYLYHEdH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #495. Fixes from the 2026-10-16 full code review (research/wind/2026-10-16-full-code-review.md), each finding adversarially verified, each diff reviewed by a second agent with follow-ups applied.
Commits:
Gates: build.bat check, build.bat test, Playwright and test:rules pass on this branch and on the combined test build (669 unit tests, 212 Playwright). Combined build deployed signed for owner testing.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TdjopXZfsUiesYxYLYHEdH