Repository navigation
fix(config,tray): review findings: profile seed, discard failures, phantom profiles, tray dialogs (#496) - #502
Merged
Merged
Conversation
…seed, report a failed discard (#496) - ListProfileFiles keeps only long names ending in .ini; *.ini also matches 8.3 short names, so a backup like Work.ini_bak listed as a phantom profile. - EnsureProfilesSeeded returns whether the profiles dir is in place. createProfile fails on a rolled-back seed instead of creating the dir (the latch) with no Default.ini. - discardSession replies with discarded:false when the session could not be reset; Settings shows "Couldn't discard" and stops the switch, close or quit, so a following switch cannot mirror the unsaved session into the outgoing profile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TdjopXZfsUiesYxYLYHEdH
…on failure and on Wind exit (#496) - After the prompt, re-read under the lock: stop if the active profile changed meanwhile, and Discard re-reads the profile file instead of the pre-prompt snapshot. - A TaskDialogIndirect failure stops Quit or the switch (logged, balloon) instead of dropping the session unasked. - A timer callback cancels the prompt when the served Wind exits, so the stale tray releases its mutex and never saves into, or quits, a restarted Wind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TdjopXZfsUiesYxYLYHEdH
… the tray prompt rules (#496) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TdjopXZfsUiesYxYLYHEdH
…rror EnsureProfilesSeeded treats CreateDirectoryW failing with ERROR_ALREADY_EXISTS (another process created the profiles dir in the race) as success. OnDiscardSession captures GetLastError() inside the locked block on each failure branch and logs that value after the lock is released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TdjopXZfsUiesYxYLYHEdH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #496. Fixes from the 2026-10-16 full code review (research/wind/2026-10-16-full-code-review.md), each finding adversarially verified, each diff reviewed by a second agent with follow-ups applied.
Commits:
Gates: build.bat check, build.bat test, Playwright and test:rules pass on this branch and on the combined test build (669 unit tests, 212 Playwright). Combined build deployed signed for owner testing.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TdjopXZfsUiesYxYLYHEdH