Skip to content

Fix insecure defaults: enforce required secrets in docker-compose and expand insecure-key blocklist #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximumTrainer merged 2 commits into from
Apr 1, 2026
Merged

Fix insecure defaults: enforce required secrets in docker-compose and expand insecure-key blocklist #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d661a4a
Initial plan
Copilot Apr 1, 2026
8fede6b
fix: remove insecure defaults and enforce required secrets in docker-…
Copilot Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/src/main/kotlin/com/opendatamask/config/StartupSecurityValidator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ private val INSECURE_JWT_DEFAULTS = setOf(
)

private val INSECURE_ENCRYPTION_DEFAULTS = setOf(
"0123456789abcdef"
"0123456789abcdef",
"change-this-16-char-key-for-prod"
)

@Component
Expand Down
9 changes: 9 additions & 0 deletions backend/src/test/kotlin/com/opendatamask/config/StartupSecurityValidatorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,13 @@ class StartupSecurityValidatorTest {
)
assertThrows<IllegalStateException> { validator.validate() }
}

@Test
fun `validate throws when ENCRYPTION_KEY is the docker-compose fallback default`() {
val validator = createValidator(
jwtSecret = "secure-jwt-secret",
encryptionKey = "change-this-16-char-key-for-prod"
)
assertThrows<IllegalStateException> { validator.validate() }
}
}
4 changes: 2 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ services:
DATABASE_URL: jdbc:postgresql://postgres:5432/opendatamask
DATABASE_USERNAME: opendatamask
DATABASE_PASSWORD: opendatamask
JWT_SECRET: ${JWT_SECRET:-change-this-secret-in-production-must-be-at-least-256-bits-long}
ENCRYPTION_KEY: ${ENCRYPTION_KEY:-change-this-16-char-key-for-prod}
JWT_SECRET: ${JWT_SECRET:?JWT_SECRET must be set (generate with: openssl rand -base64 32)}
ENCRYPTION_KEY: ${ENCRYPTION_KEY:?ENCRYPTION_KEY must be set (generate with: openssl rand -base64 32)}
SERVER_PORT: 8080
depends_on:
postgres:
Expand Down
Loading