-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor to decoupled CQRS architecture with RabbitMQ event bus and dual-database deployment #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2bad3e9
Initial plan
Copilot 3d3c596
Add CQRS event bus infrastructure: RabbitMQ publisher, in-memory bus,…
Copilot 7e25b2f
Add CLI query-host support, update docker-compose with dual PostgreSQ…
Copilot 4eda541
Address code review feedback: fix comments, add error handling, clari…
Copilot f20d2cf
Address all 9 PR review comments: shared event registry, split exchan…
Copilot 53507b2
Add error handling to EventAppender afterCommit callback and RabbitMq…
Copilot 35bc9f8
Address review thread 2: timestamps from event.occurredAt, improved e…
Copilot f5b5110
Fix QueryServiceReadOnlyFilter: add TRACE, remove unnecessary upperca…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README presents the query service as GET-only, but in the current codebase the v2 command controllers (e.g. FlowCommandController) are not gated on FACTSTORE_CQRS_ROLE/factstore.cqrs.role and will still be registered in the query container (same JAR + prod profile). That means the query host can accept POST/PUT/DELETE and mutate the read database if called directly. Consider documenting this caveat or (preferably) enforcing it by conditionally enabling command/query web adapters based on factstore.cqrs.role (or by blocking non-GET methods on the query role).