Add options for vertical OR horizontal menu.#2
Open
rhysperry111 wants to merge 12 commits intoMaxr1998:masterfrom
Open
Add options for vertical OR horizontal menu.#2rhysperry111 wants to merge 12 commits intoMaxr1998:masterfrom
rhysperry111 wants to merge 12 commits intoMaxr1998:masterfrom
Conversation
I have no experience writing GTK apps. I hope this works. Once i have done this i will work on making it a command line option.
Still not tested (i hope it works!)
This will allow the layout to be determined from the command line
This is my first attempt at C so i hope it works :)
Owner
|
Thanks, I'll review it more closely once I find time in the coming weeks! I'm not 100% happy though with the duplicated layout code, maybe it's possible to combine this somehow. |
Author
|
I don’t like it either, but I dot have much experience in C and none with GTK so I couldn’t think of a different way of implementing it. In the mean time I will do some googling and see if there is a way of implementing it in a different way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added functionality to access a horizontal mode by passing the
-hoption.For sake of keeping a standard I have also added the
-vtag for vertical layout, but this is not needed as that is the default anyway.I am also sorry if my code lacks standard. This is my first time coding in C and I have been trying to keep things up to the best standard that I can do.