refactor: rename API entry points to snake_case and centralize settings

[MrIbrahem]

No description provided.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c84d7815-0f08-40ce-8894-fe2002dec0b9

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[MrIbrahem]

Review summary

This PR standardizes API entry points to snake_case and centralizes config under main_settings. The rename is thorough for most of src/, but I found 3 runtime-breaking call sites that were missed, plus a scope gap with the src1/ tree.

Verdict: Comment 💬 (forced — you're the PR author; underlying assessment is 🔴 blocking issues found)

Title

The title "Update" is too vague and doesn't describe the change. The repo's recent history is inconsistent (many blank/vague titles), but descriptive Refactor ... / Migrate ... prefixes are used. Suggested alternatives:

• refactor: rename API entry points to snake_case and centralize settings
• chore: normalize wiki API naming and settings access
• refactor(newapi): snake_case API helpers + main_settings

Also, the PR body is empty — I can fill it in from the diff/commit message if you want.

Highlights

• Consistent, repo-wide snake_case rename of API helpers (GetPageText→get_page_text, NewApi→newapi, etc.).
• mdwiki_api.mdwiki_page keeps NewApi/MainPage/CatDepth as backward-compatible aliases — good for limiting blast radius.
• bot_edit/__init__.py nicely extracted into edit_checker.py.
• Good defensive fix in cookies_client.py (accept None path, default cookies_dir).

Issues found

• 🔴 Blocking: 3 — see inline comments
  • bot_api.py:726 calls post_continue_list positionally after it became keyword-only → TypeError.
  • fixour.py:69 and fix_cs1/fix_cs_params/bot.py:311 still call the renamed Get_All_pages → AttributeError.
• 🟡 Suggestions: 3 (unused is_bot/mainpagesolvereditect, int | Any type, plus the title/body above)

Scope note (needs confirmation, not necessarily blocking)

The commit says it updates call sites "across the codebase," but the large src1/ tree was not touched and still references the old names (GetPageText, Get_All_pages, NewApi, MainPage, Find_pages_exists_or_not, Get_template_pages, Get_UserContribs). If src1/ is still deployed/run, those entry points also break. Please confirm whether src1/ is in scope, and consider adding a CI grep to catch missed renames in future.