Refactor DB access, API naming, and enhance type safety

[MrIbrahem]

Summary

Refactors database access, renames API entry points from PascalCase to snake_case, and adds type annotations across the codebase. The generic mdwiki_sql/toolforge_tools_sql_connect helpers are replaced by dedicated mdwiki_sql_update (writes) and mdwiki_sql_dict (reads) functions, and legacy select_md_sql is removed.

Changes

• DB layer: split wiki_sql_connect/toolforge_tools_sql_connect into tf_sql_connect_update and tf_sql_connect_dict; replace mdwiki_sql(...)/select_md_sql(...) with mdwiki_sql_update(...)/mdwiki_sql_dict(...) in sql_for_mdwiki and all callers.
• API renames (snake_case): Get_All_pages→get_all_pages, search→api_search, Get_claim→get_claim, Get_sitelinks_From_Qid→get_sitelinks_from_qid, WD_Merge→wd_merge, Get_Claims_API→get_claims_api, usercontribs→user_contribs, get_pageassessments→get_page_assessments, isRedirect→isredirect, Get_tags→get_tags, etc.
• Type safety: add dict[str, Any] / list[...] annotations throughout src/db, src/newapi, src/md_core*, src/wprefs, and mark os.getenv(...) reads with or "" defaults.
• super_page.MainPage: add is_bot_edit_invalid guard (blocks bot edits with empty summaries); minor reordering of helper methods.
• bot_api: add get_page_info_from_wikipedia; defensive params.pop("apnamespace", None).

Testing

No tests included.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 74997e3b-3059-4472-b69e-19b2b56b6cc1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[MrIbrahem]

Review summary

Large mechanical refactor (split DB helpers + snake_case renames + type annotations). Intent is good and most edits are consistent, but the core DB helper is broken and several renamed callers were left dangling.

Verdict: Comment 💬 (forced — you're the PR author; underlying assessment is 🔴 blocking issues found)

Title

Current: Refactor DB access, API naming, and enhance type safety

• The title is accurate. Optional: prefix with refactor: to match the recent conventional-commit style seen in merged PRs (e.g. refactor: split DB helpers and rename API methods to snake_case). Not required.

Highlights

• Consistent snake_case rename across the API surface (Get_All_pages→get_all_pages, search→api_search, Get_claim→get_claim, etc.).
• Good defensive fix: params.pop("apnamespace", None) instead of del (avoids KeyError).
• New is_bot_edit_invalid guard blocks bot edits with empty summaries — sensible safety check.
• Type annotations added broadly without restructuring logic.

Issues found

• 🔴 Blocking: 4 (see inline comments + the items below that fall outside the diff hunks).
• 🟡 Suggestions: 3

Blocking (details)

1. src/db/mdapi_sql/sql_td_bot.py — DbConfig.to_dict() raises KeyError: 'conv' on every call. The conv key was removed from the dict literal but is still accessed on the line before it's created. Every DB query in this PR goes through _load_db_config().to_dict(), so all DB access crashes. Even after fixing the crash, the DATE→str converter is lost because data["conv"] is overwritten on the next line after the override is applied.
2. tf_sql_connect_update returns False on the success path (the only return statements are return False), so every INSERT/UPDATE/DELETE reports failure regardless of outcome.
3. Renamed/removed methods still referenced in this PR's own touched files (not inline-commentable because they sit outside the diff hunks — please fix):
   • src1/md_core/mdpy/red.py:210,243,245 → api_new.Search, api_new.Get_Newpages, mdwiki_api_call.Get_UserContribs
   • src1/md_core/mdpy/imp.py:163,196 → api_new.Search, api_new.Get_Newpages
   • src1/newupdater/medask.py:131,149,151 → api_new.Search, api_new.Get_Newpages, mdwiki_api_call.Get_UserContribs
   • api_search also dropped the return_dict parameter — replace1.py:127 / one_job.py:168 still pass return_dict=False, which is now an invalid kwarg (TypeError). And api_search now always returns dicts (full search hits), not title strings, so any downstream code expecting strings must be updated.
4. sql_for_mdwiki.select_md_sql was deleted but is still used in untouched files: src1/md_core/mdpy/orred.py:55 and src1/copy_text/text_bot.py:21 → AttributeError.

Suggestions

• 🟡 Add a smoke test that imports sql_td_bot and calls to_dict() (and ideally opens a connection) — the KeyError would have been caught immediately.
• 🟡 After a repo-wide rename, grep for the old names to catch dangling callers (the src1/ breakage above).
• 🟡 The repeated params: dict[str, Any] = {...} local-variable annotations are valid but noisy; reverting to plain params = {...} is optional.