Skip to content

37 reduce api footprint #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Niphyr merged 2 commits into from
Oct 25, 2025
Merged

37 reduce api footprint #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0126d9
Change public interfaces and classes to internal
Niphyr Oct 25, 2025
4f9a5bf
Merge pull request #119 from MechanicalPriest/76-add-method-to-update…
Niphyr Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SimcProfileParser/Interfaces/DataSync/ICacheService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace SimcProfileParser.Interfaces.DataSync
/// <summary>
/// A service for keeping local parsed json files ready for use.
/// </summary>
public interface ICacheService
internal interface ICacheService
{
/// <summary>
/// The base directory the cache service stores its files
Expand Down
2 changes: 1 addition & 1 deletion SimcProfileParser/Interfaces/ISimcItemCreationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace SimcProfileParser.Interfaces
{
public interface ISimcItemCreationService
internal interface ISimcItemCreationService
{
Task<SimcItem> CreateItemAsync(SimcParsedItem parsedItemData);
Task<SimcItem> CreateItemAsync(SimcItemOptions itemOptions);
Expand Down
2 changes: 1 addition & 1 deletion SimcProfileParser/Interfaces/ISimcParserService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace SimcProfileParser.Interfaces
{
public interface ISimcParserService
internal interface ISimcParserService
{
SimcParsedProfile ParseProfileAsync(List<string> profileString);
}
Expand Down
2 changes: 1 addition & 1 deletion SimcProfileParser/Interfaces/ISimcSpellCreationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace SimcProfileParser.Interfaces
{
public interface ISimcSpellCreationService
internal interface ISimcSpellCreationService
{
Task<SimcSpell> GenerateItemSpellAsync(SimcItem item, uint spellId);
Task<SimcSpell> GenerateItemSpellAsync(SimcSpellOptions spellOptions);
Expand Down
2 changes: 1 addition & 1 deletion SimcProfileParser/Interfaces/ISimcTalentService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace SimcProfileParser.Interfaces
{
public interface ISimcTalentService
internal interface ISimcTalentService
{
Task<SimcTalent> GetTalentDataAsync(int talentId, int rank);
Task<List<SimcTalent>> GetAvailableTalentsAsync(int classId, int specId);
Expand Down
2 changes: 1 addition & 1 deletion SimcProfileParser/Interfaces/ISimcVersionService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace SimcProfileParser.Interfaces
{
public interface ISimcVersionService
internal interface ISimcVersionService
{
Task<string> GetGameDataVersionAsync();
}
Expand Down
2 changes: 1 addition & 1 deletion SimcProfileParser/SimcGenerationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public class SimcGenerationService : ISimcGenerationService
/// <param name="simcVersionService">Service for retrieving game data version information.</param>
/// <param name="simcTalentService">Service for fetching and processing talent data.</param>
/// <param name="cacheService">Service for caching and retrieving raw game data files.</param>
public SimcGenerationService(ILogger<SimcGenerationService> logger,
internal SimcGenerationService(ILogger<SimcGenerationService> logger,
ISimcParserService simcParserService,
ISimcItemCreationService simcItemCreationService,
ISimcSpellCreationService simcSpellCreationService,
Expand Down
2 changes: 1 addition & 1 deletion SimcProfileParser/SimcParserService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace SimcProfileParser
{
public class SimcParserService : ISimcParserService
internal class SimcParserService : ISimcParserService
{
private readonly ILogger<SimcParserService> _logger;

Expand Down
6 changes: 3 additions & 3 deletions SimcProfileParser/SimcProfileParser.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<PropertyGroup>
<TargetFrameworks>net9.0</TargetFrameworks>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Version>3.1.1</Version>
<AssemblyVersion>3.1.1</AssemblyVersion>
<FileVersion>3.1.1</FileVersion>
<Version>3.1.2</Version>
<AssemblyVersion>3.1.2</AssemblyVersion>
<FileVersion>3.1.2</FileVersion>
<Authors>Mechanical Priest</Authors>
<Company>Mechanical Priest</Company>
<PackageLicenseExpression>GPL-3.0-only</PackageLicenseExpression>
Expand Down