fix: deployment fixes and doc update#21
Merged
Merged
Conversation
ThanKarab
approved these changes
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Argo CD bootstrap/deployment documentation and adjusts Argo CD setup inputs, including bumping the pinned upstream Argo CD HA manifest version.
Changes:
- Remove an outdated/incorrect
sourceReposentry from the infrastructure AppProject. - Refresh bootstrap/RBAC documentation to match the current
argo-setup/overlay and patch filenames/paths. - Bump the pinned upstream Argo CD HA manifest in
argo-setup/patches/kustomization.yamlfromv3.3.9tov3.3.11.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
projects/mip-infrastructure.yaml |
Removes an outdated sourceRepos entry from the infrastructure AppProject. |
docs/rbac-layers.md |
Updates RBAC doc references and Argo CD pinning note. |
docs/getting-started.md |
Simplifies Argo CD install instructions and fixes a bootstrap manifest path reference. |
argo-setup/README.md |
Updates overlay README to the new bootstrap flow and documents upgrade procedure. |
argo-setup/patches/kustomization.yaml |
Bumps the pinned upstream Argo CD HA manifest URL to v3.3.11. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+28
to
+31
| [`argo-setup/README.md` § Bootstrap](../argo-setup/README.md#bootstrap) - | ||
| they cover hostname rewrite, namespace creation, `kustomize build … | | ||
| kubectl apply --server-side`, rollout wait, and bootstrap admin-password | ||
| rotation. From off-cluster you'll need a tunnel + `/etc/hosts` mapping for |
| --- | ||
|
|
||
| Pinned at Argo CD [v3.3.9](../argo-setup/patches/kustomization.yaml). To bump: | ||
| Pinned at Argo CD (../argo-setup/patches/kustomization.yaml). To bump: |
| kubectl -n "$ARGOCD_NS" get ingress | ||
| kubectl -n "$ARGOCD_NS" get certificate argocd-server-tls \ | ||
| -o jsonpath='{.status.conditions[?(@.type=="Ready")].status}{"\n"}' | ||
| argocd login "$ARGOCD_HOST" --grpc-web |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.